Change request method strategy when validating access token #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a known issue with the LinkedIn API (and other oAuth2 APIs too) when sending an access token provided in the body of a POST request that returns random REVOKED_ACCESS_TOKEN responses. The workaround is to provide the same access token via query params of a POST request instead. Thankfully, the `oauth2` gem already as a setting for that matter, and it's implemented in this commit.
jclusso
approved these changes
Sep 19, 2024
|
Thanks @batalla3692 for getting to the bottom of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Resolves #6)
There is a known issue (since 10 years ago) with the LinkedIn API when getting an access token sending the params in the body of a
POSTrequest, that returns randomREVOKED_ACCESS_TOKENresponses.There is also an open issue in the
omniauth-linkedin-oauth2repository about the same error that has a lot more details.The workaround is to provide the same params as query params for the
POSTrequest instead of body params. Thankfully, theoauth2gem already has a setting for this, so the fix is quite easy.I tested this on a production site and the random
REVOKED_ACCESS_TOKENerrors seems to be fixed now.