Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Add possibility to use 'rclone delete' jobs #75

Closed
ZiroNL opened this issue Aug 9, 2024 · 3 comments · Fixed by #78
Closed

[FR]: Add possibility to use 'rclone delete' jobs #75

ZiroNL opened this issue Aug 9, 2024 · 3 comments · Fixed by #78
Labels

Comments

@ZiroNL
Copy link

ZiroNL commented Aug 9, 2024

Is your feature request related to a problem? Please describe.

I use the addon for 'rclone copy' jobs, which works very nice. The destination is never cleaned up automaticly, old backup files must be deleted manualy.
It would be nice to use the addon for a 'rclone delete' job to delete backup files older then X days or months.

Describe the solution you'd like

'rclone delete' jobs are not accepted right now. There is no source needed for this command, but the addon give's an error when it is removed or not filled in (in the config). When it is filled in with an fake one, the rclone command gives an error because of the source that is given and not needed.

Describe alternatives you've considered

No response

Additional context

No response

@jcwillox
Copy link
Owner

jcwillox commented Aug 10, 2024

I'll give this a test later but you can just provide a source and no destination, the source is what the delete command will target.

Here's and example with the ls command, I imagine it'll be the same for delete.

- command: ls
  name: List Backups
  source: "hassbackup:"
# or
- command: ls
  name: List Local Backups
  sources:
    - /backup
  extra_flags:
    - "--human-readable"

In those two examples, in the first one the "source" is a remote destination, and the second one is a local folder.

@Cogitri
Copy link
Contributor

Cogitri commented Aug 30, 2024

Hej, just encountered that as well. Setting source to the remote destination works just fine - it does feel a bit odd though. Maybe we can add an example for that?

Cogitri added a commit to Cogitri/hassio-rclone-backup that referenced this issue Aug 30, 2024
github-actions bot pushed a commit that referenced this issue Sep 26, 2024
### 📚 Documentation

* Add example for pruning old backups ([#78](#78)) ([01ef01a](01ef01a)), closes [#75](#75)

### 📦 Build

* **deps:** Update add-on base image to v14 ([0b743fa](0b743fa))
* **deps:** Update all non-major dependencies ([75532c9](75532c9))
* **deps:** Update all non-major dependencies ([f600337](f600337))
* **deps:** Update all non-major dependencies ([b4ea62b](b4ea62b))
* **deps:** Update all non-major dependencies ([a7b6a30](a7b6a30))

**Full Changelog**: [`v3.3.1...v3.3.2`](v3.3.1...v3.3.2)
Copy link

🎉 This issue has been resolved in version 3.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants