Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: playground #185

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: playground #185

wants to merge 12 commits into from

Conversation

IcetCode
Copy link
Contributor

@IcetCode IcetCode commented Jun 13, 2023

I've got most of the features done, but still need some help:

  • For some reason, AFloating always appears in the top left corner instead of the correct position.
  • Eslint in the playground cannot detect the @ alias path.
  • I'd also like to improve the look and feel of the UI.

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for anu-vue ready!

Name Link
🔨 Latest commit 1f54cb6
🔍 Latest deploy log https://app.netlify.com/sites/anu-vue/deploys/64bf3229a9cde40008251eda
😎 Deploy Preview https://deploy-preview-185--anu-vue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jd-solanki
Copy link
Owner

@IcetCode Why running playground nr play:dev ask for sudo password?
image

@IcetCode
Copy link
Contributor Author

That may cause by the server option in vite.config.ts configuration, you can remove it.

server: {
  https: true,
  host: true,
}

@jd-solanki
Copy link
Owner

Actually that's because of vite-plugin-mkcert plugin. Ref.

Is that plugin required?

@IcetCode
Copy link
Contributor Author

IcetCode commented Jun 13, 2023

It's for using HTTPS with vite, but it's not a must-have. We could just remove it.

@jd-solanki
Copy link
Owner

jd-solanki commented Jun 13, 2023

For some reason, AFloating always appears in the top left corner instead of the correct position.

I guess that's because of iframe No it's not because in nuxt dev tools' iframe it works fine!
image

@IcetCode
Copy link
Contributor Author

I found during debugging that it's related to the @floating-ui/vue package. When I use @floating-ui/dom instead of @floating-ui/vue to implement the floating component, it works. This is really strange, and I will try to figure out what caused this issue.

@jd-solanki
Copy link
Owner

jd-solanki commented Jun 15, 2023

For floating ui dom tooltip still appears at middle
image

Because of div is block element and we have div as target, sorry

@jd-solanki
Copy link
Owner

Have you tried in Vue Playground?

Example

It doesn't work there, I hope I have correct import map 🤔

@IcetCode
Copy link
Contributor Author

Yes, I've tried it and I got the same result as you did, but the same example works in a local project.

@jd-solanki
Copy link
Owner

I guess we should raise the issue at vue playground with local project and live playground, IDK when they will resolve the issue though 😑

@jd-solanki
Copy link
Owner

Second thought is if it works fine for dom module then we shouldn't raise it on vue side 😅

Do you mind raising issue at floating UI repo with local project, live vue & live dom example?

@IcetCode
Copy link
Contributor Author

Finally, I found out that this is a Vue issue. watch() doesn't work after running npm run build for a Vue project. Let's wait for the fix to be merged.

@IcetCode IcetCode closed this by deleting the head repository Jun 24, 2023
@jd-solanki
Copy link
Owner

@IcetCode ??

@IcetCode
Copy link
Contributor Author

@jd-solanki
Oh no, sorry, I forgot that I still have an unmerged PR. I'm trying to re-fork the repository to fix the sync issue, but it seems I can't restore it. I may need to recreate a PR.

@IcetCode
Copy link
Contributor Author

I've sent a restore ticket to see if I can restore it. If not, I will create a new PR.

@IcetCode IcetCode reopened this Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants