Improve derridaean_similarity using quantum (qrng) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2023 11:53
…idaean_similarity where random number generation is positively the only factor affecting output Misc: cleanup python formatting according to PEP rules in pycharm and fix path issues demo.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
derridaean_similarity is pretty damn good, after testing, but its output is entirely predicated on the quality of the random number generation.
This PR proposes an optional quantum toggle that will enable quantum random number generation using 8-qubit simulated system to provide quantifiably more robust random number output.
I did some benchmarks and quantumfied derridaean_similarity is approximately 3.5m (m as in million) times slower than non-quantum but I believe the results speak for themselves. Due to the speed cost, I have set it to default to false.
p.s. Please accept my apology for premature rant in issue #2. I have come to my senses. I wish to contribute to the hypeDB moving forward.
@rjadr @jdagdelen @jobergum