Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limiting doesn't work anymore #165

Closed
max-wittig opened this issue Aug 20, 2018 · 6 comments
Closed

Rate limiting doesn't work anymore #165

max-wittig opened this issue Aug 20, 2018 · 6 comments

Comments

@max-wittig
Copy link
Contributor

Looks like node-gitlab no longer obeys the rate-limit, but throws 429 again.

I'm guessing that it broke in bc3b366#diff-6e04893ff7542559430b953f9c1293d0

@jetersen
Copy link
Contributor

Yes I wondered the same when I saw the commit. Your welcome to open a PR to fix it and then you can also verify it is working

Perhaps a mock test to avoid breaking it again 😄

@max-wittig
Copy link
Contributor Author

max-wittig commented Aug 20, 2018

I think it still works, but I've only implemented it for get requests for some reason before in 9b46250.

I will prepare a PR.

@jdalrymple
Copy link
Owner

Not sure how i didnt notice that before smh. Depending on #98 the got library handles retries too!

max-wittig added a commit to max-wittig/node-gitlab that referenced this issue Aug 21, 2018
max-wittig added a commit to max-wittig/node-gitlab that referenced this issue Aug 21, 2018
jdalrymple pushed a commit that referenced this issue Aug 28, 2018
## [3.11.2](3.11.1...3.11.2) (2018-08-28)

### Bug Fixes

* obey rate limits for all request types correctly ([#170](#170)) ([4bc7c69](4bc7c69)), closes [#165](#165)
* Testing negated npmignore ([86960c4](86960c4))
@jdalrymple
Copy link
Owner

🎉 This issue has been resolved in version 3.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@max-wittig
Copy link
Contributor Author

max-wittig commented Jun 12, 2020

@jdalrymple Rate limiting actually broke again with the new custom requester approach. I still don't know how to use the custom requesters. There seem to be no example on how to use got for example. I'm just importing the library like so and no requester is defined:

const {Gitlab} = require('@gitbeaker/node');

ReferenceError: Requester must be passed

@jdalrymple
Copy link
Owner

Sorry this is on me! Latest build has some issues apparently #885. Looking into this now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants