-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rate limiting doesn't work anymore #165
Comments
Yes I wondered the same when I saw the commit. Your welcome to open a PR to fix it and then you can also verify it is working Perhaps a mock test to avoid breaking it again 😄 |
I think it still works, but I've only implemented it for get requests for some reason before in 9b46250. I will prepare a PR. |
Not sure how i didnt notice that before smh. Depending on #98 the got library handles retries too! |
🎉 This issue has been resolved in version 3.11.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@jdalrymple Rate limiting actually broke again with the new custom requester approach. I still don't know how to use the custom requesters. There seem to be no example on how to use const {Gitlab} = require('@gitbeaker/node');
|
Sorry this is on me! Latest build has some issues apparently #885. Looking into this now! |
Looks like node-gitlab no longer obeys the rate-limit, but throws 429 again.
I'm guessing that it broke in bc3b366#diff-6e04893ff7542559430b953f9c1293d0
The text was updated successfully, but these errors were encountered: