WIP: Attempt to remove the dependencies on fs for browser usage

[jdalrymple]

Summary

fix: Removed xhr library in favour of ky, and switched request for got for a smaller package size and retry functionality #98

breaking: Removed dependency on FS. Now the Projects API takes in two arguments projectId and content as well as an option fileName argument

Testing

1. Attempt to upload a file to a project https://docs.gitlab.com/ee/api/projects.html#upload-a-file through this library
2. Test a few other endpoints to make sure the got library replacement worked
3. Test this library in the browser to see if the replacement through the browser package.json change worked properly using ky instead of got

[jetersen]

LGTM, nice cleanup 🙌

[jdalrymple]

Still testing! 😎

[jdalrymple]

Not sure if im doing the browser bundling correctly:

    "build:browser": "browserify src/index.ts -p [ tsify --noImplicitAny ] > dist/browser.js",

but then i get this error:

> gitlab@4.2.0 build:browser /home/hyde/Projects/Libraries/node-gitlab
> browserify src/index.ts -p [ tsify --noImplicitAny ] > dist/browser.js

TypeScript error: node_modules/@types/node/index.d.ts(6406,21): Error TS2451: Cannot redeclare block-scoped variable 'promisify'.

Any ideas?

[jdalrymple]

Finally sorted out the above issue, but ran into another problem. The replacement library Ky, for handling requests has been build to support the latest browsers. I have no issue just supporting the latest browsers for the browser build of this library.

That being said, it will still have to be bundled. If we use the default Ky library, we cannot use browserify since it will only work with es5 modules. This leaves a couple options:

1. Compile the Ky library down to es5 and use browserify
2. Don't use browserify, instead use another bundler such as webpack

Thoughts?

[jetersen]

Don't bother going down the path of compiling Ky and browserify.
Use webpack I could foresee we need it for other bundle options.

Most of electron everything apart from Internet explorer supports es6
So why actually worry about es5 support? Can't the user not polyfill most of it anyway?
https://caniuse.com/#search=es6
https://caniuse.com/#search=Async%20functions

[jdalrymple]

Yup! Switched to rollup and everything seems to be working except TrySound/rollup-plugin-terser#11. Hopefully i get that sorted soon!

[jetersen]

LGTM so far

[jetersen]

hmmm maybe .editorconfig would be good to add and set insert final new line. Your making the next edit harder without final new line

[jdalrymple]

Any suggestions for a good editorconfig?

[jetersen]

This seems to apply for the whole repo, of course you can apply different rules for each file type: https://editorconfig.org/

root = true

[*]
end_of_line = lf
charset = utf-8
insert_final_newline = true
ident_style = space
ident_size = 2

[jdalrymple]

Just need to figure out the tests then i can merge this!

[jetersen]

Looks really promising 🙌

[jdalrymple]

Trying to sort issue with named imports rollup/rollup#2521. We could use { esModuleInterlop: true } in the tsconfig, but im REALLY trying to avoid that if possible.

[jdalrymple]

Hmm even when i disable treeshaking, the es output is still broken. The top two lines of the output file are:

import * as Request from 'got';
import { get, stream, post, put, delete } from 'got';

I'm not sure why the second line is present since i included the treeshaking: false argument. Ill keep investigating

[jdalrymple]

Found a way around the treeshaking problem ;)

[jdalrymple]

Update: My 'genius' idea isn't testable 👎

[jdalrymple]

sindresorhus/got#657
sindresorhus/ky#61

[jdalrymple]

Couldnt get around it, had to include the esModuleInterop