Update to Webpack 4 and fix a lot of things #145
Conversation
| .arcconfig | ||
| .arclint | ||
| .travis.yml | ||
| .eslintrc |
There was a problem hiding this comment.
Don't see much point in packaging these sorts of things.
| "test", | ||
| "tests" | ||
| ] | ||
| } |
There was a problem hiding this comment.
bower is dead and I think keeping this around is only going to leave it going stale
| devServer: { | ||
| open: true, | ||
| openPage: "test" | ||
| } |
There was a problem hiding this comment.
This bit is new. It opens our test page when the dev server launches.
| veryimportant, | ||
| autoprefixer({browsers: ["> 1%"]}), | ||
| plugins: [ | ||
| new CleanWebpackPlugin(), |
There was a problem hiding this comment.
This bit is new.
| plugins, | ||
| postcss: [ | ||
| veryimportant, | ||
| autoprefixer({browsers: ["> 1%"]}), |
There was a problem hiding this comment.
Moved to plugins.
somewhatabstract
changed the title
| @@ -13,7 +13,7 @@ const plugins = require("./plugins"); | |||
| const logoTemplate = require("./templates/logo.handlebars"); | |||
|
|
|||
| // Chrome Accessibility Developer Tools - required once as a global | |||
| require("script!./node_modules/accessibility-developer-tools/dist/js/axs_testing.js"); | |||
| require("script-loader!./node_modules/accessibility-developer-tools/dist/js/axs_testing.js"); | |||
There was a problem hiding this comment.
That's annoying that they don't have a UMD version.
There was a problem hiding this comment.
There might be a better way, now. But that'll have to be a different change. :)
| "name": "tota11y", | ||
| "version": "0.1.6", | ||
| "name": "@khanacademy/tota11y", | ||
| "version": "0.2.0", |
package.json
Outdated
| "lint": "eslint index.js plugins test utils", | ||
| "test": "mocha --require test/babel-hook test/*.js", | ||
| "live-test": "webpack-dev-server --config webpack.config.babel.js --hot --inline" | ||
| "test:live": "webpack-dev-server --config webpack.config.babel.js --hot --inline", | ||
| "start": "npm run test:live", |
There was a problem hiding this comment.
What's the use of test:live if it's the same thing as start?
There was a problem hiding this comment.
Great point!
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/Khan/tota11y.git" | ||
| }, | ||
| "author": "Jordan Scales <scalesjordan@gmail.com>", | ||
| "contributors": [ | ||
| "Jeff Yates <jeff.yates@alumni.manchester.ac.uk" |
There was a problem hiding this comment.
This is cool. I think I'll suggest this for KaTeX as well.
There was a problem hiding this comment.
Yeah, I think it should be voluntary (hence why I haven't populated it with all the folks that have had changes merged), but we should ask folks if they want to be in this list.
| <script src="http://localhost:8080/webpack-dev-server.js"></script> | ||
| <script src="../tota11y.min.js"></script> | ||
| <script src="/webpack-dev-server.js"></script> | ||
| <script src="/tota11y.js"></script> |
| // Make the JSX pragma function available everywhere without the need | ||
| // to use "require" | ||
| new webpack.ProvidePlugin({ | ||
| [options.jsxPragma]: path.join(__dirname, "utils", "element"), |
There was a problem hiding this comment.
I'm a little unclear exactly what this is doing, but this is what we were doing before so I guess it's alright.
There was a problem hiding this comment.
My understanding is that this allows us to use JSX without React. We inject our own calls to support creating elements so that when JSX is compiled to JS, it will work.
This addresses #141, #126, and #125.
It upgrades us to Webpack 4 and all the latest loaders and related things. Also updates handlebars and a couple of other things to address some newer security audit issues.
Also adds some new
npmscripts to make development easier and splits dev and prod builds properly. It also removes build assets from the repo (we'll have to update the Github pages accordingly) and gets us ready to start publishing tonpm.Complete list of changes in the commits.