Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steps to make tota11y more screen-reader friendly and keyboard-accessible #71

Merged
merged 1 commit into from
Sep 27, 2015

Conversation

jdan
Copy link
Owner

@jdan jdan commented Sep 20, 2015

This PR adds several features to make tota11y more keyboard and screen-reader friendly, notably:

  • Adding keyboard toggling to the list of plugins (and a focus indicator)
  • Adding screen reader text to the toolbar expand button, close buttons in the info panel, and "scroll to error" buttons in the info panel entries
  • When activating a plugin, focus is directed to the newly-created info panel
  • Menu aria roles on the list of plugins

I am still struggling to make annotations screen reader friendly, as they are located near the errors to sighted users, but for screen readers there is no strong connection. I am thinking that the "Scroll to error" button can be repurposed to focus the violating element.

@rileyjshaw || @MichelleTodd - would you mind reviewing the code in this diff? a11y-wise, I'll keep exploring more options, but this is definitely a step in the right direction.

@jdan jdan changed the title Added keyboard a11y to tota11y - Fixes #47 Steps to make tota11y more screen-reader friendly and keyboard-accessible Sep 20, 2015
@rileyjshaw
Copy link
Contributor

(Sorry that I haven't gotten to this yet - I can check it out by the end of the week if that's okay?)

@jdan
Copy link
Owner Author

jdan commented Sep 22, 2015

Yeah no huge rush here. It's a big scary diff but there isn't that much going on. Mainly moving handlebars -> JSX (maybe that should be its own diff)

@allofthenorthwood
Copy link
Contributor

all of this looks good to me! thank you for splitting your code up into such small & well-defined commits! :D

@rileyjshaw
Copy link
Contributor

Woohooooooo jsx!!

Just took a peek at this, looks cool :)

jdan added a commit that referenced this pull request Sep 27, 2015
Steps to make tota11y more screen-reader friendly and keyboard-accessible
@jdan jdan merged commit c12f320 into master Sep 27, 2015
@jdan jdan deleted the a11y branch September 27, 2015 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants