Windows Powershell readme update + Decimal vs * 10 w/ early return

[Luffles]

Probably moot w/ git bash or wsl, but might be useful for people who forget about it until it's done (me)

[Luffles]

sorry i didn't test this on my macbook, i assume everything is fine and it will Just Work ™

maybe decimal isn't what you intended for output, but i think it looks better for win rate %, imo.

apologies if you weren't looking for PRs to this @jdb8 .

[jdb8]

@Luffles always happy to accept PRs, thanks for taking the time!

Regarding the percentage display, the reason I went with 3-digit displays for win rate (like 568 for a card with a 56.8% deck win rate) is because the macOS version of HSTracker seems to only be able to display numbers, not decimals (and only supports up to 3 digits). So in order to make sure we have the full percentage visible, it needs to be formatted that way unfortunately. Example:

This limitation might not apply to the Windows version, but unfortunately I don't have a Windows machine to test on at the moment. I'm actually surprised this repo is even useful for Windows, since I thought that HSReplay win rates were already implemented outside of macOS.

If this repo is also useful for Windows then I'd be open to supporting a flag to choose whether the script outputs percentages or 3-digit numbers, but I'd want to keep the default as 3-digits to ensure that the macOS usecase works out of the box.

[Luffles]

@Luffles always happy to accept PRs, thanks for taking the time!

Cool, thanks for taking a look.

If this repo is also useful for Windows

I ran into Overwolf being incredibly resource intensive while trying to multitask with arena on the side -- and maybe I'm missing something with deck tracker -- but I get the almost entirely N/A value on cards using the latest repo release, after the source of the value stopped updating.

[jdb8]

@Luffles sorry for neglecting this PR. The README updates look fine to me, although I don't have a Windows machine to test them on (but they look correct and I'm assuming you've run them on your machine).

I'm less sure about the code change though: it seems like the Windows deck tracker is fine with decimals, but Mac isn't. I'd be happy to add conditional behaviour here if you can easily detect whether we're running on Windows or Mac - as long as the default Mac behaviour is to maintain the 3-digit display.