-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: extend mongodb compatibility to 6.x #473
Conversation
Added fix for failed build. |
Looks like the build needs to be manually approved, any maintainer out there willing to run it? @jdesboeufs @mingchuno |
That would be great.... GOGOGO |
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #473 +/- ##
=======================================
Coverage 82.12% 82.12%
=======================================
Files 2 2
Lines 179 179
Branches 42 42
=======================================
Hits 147 147
Misses 21 21
Partials 11 11 ☔ View full report in Codecov by Sentry. |
@MarkoCen, could you please approve it and merge ? |
I will look at this. |
Any chance to merge this PR soon and create new release? |
Since This module doesn't use specific |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
I suggest some changes so we will be able to release a minor version quickly, and then we will release a major dropping old Node.js versions.
@jdesboeufs Thanks for reviewing! Implemented changes, please take a look. |
Hmm do we have to drop Node 14 if we want to support mongodb v6? |
No but sanity workflow must be updated according to relaxed peer dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And to test against mongodb@6
I suggest you to add a new step in sanity.yml
.
Something like this:
- run: yarn add mongodb@^6 && yarn test
if: ${{ matrix.node-version !== '4.x' }}
package.json
Outdated
@@ -58,7 +58,7 @@ | |||
}, | |||
"peerDependencies": { | |||
"express-session": "^1.17.1", | |||
"mongodb": "^5.1.0" | |||
"mongodb": ">= 5.0.0 < 7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a mistake here
"mongodb": ">= 5.0.0 < 7" | |
"mongodb": ">= 5.1.0 < 7" |
package.json
Outdated
@@ -95,7 +95,7 @@ | |||
"gh-pages": "^3.1.0", | |||
"husky": "4", | |||
"lint-staged": "^10.5.4", | |||
"mongodb": "^5.1.0", | |||
"mongodb": "^6.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally please let this part unchanged at the moment.
If you prefer I can finish. No problem with this :) |
OK, updated. Not sure if the extra CI step is in the right place, let me know if it needs fixing. |
Updates the
mongodb
dependency from v5.0.0 to v6.0.0.I didn't see anything in the release notes to warrant changes to the code, so this PR just updates the MongoDB and Node versions, following the PR for v5.
Checklist:
[n/a] Added test cases
Updated changelog