Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text borders in diff editor #42

Merged
merged 2 commits into from
Sep 4, 2021
Merged

Conversation

klaussner
Copy link
Contributor

Setting the diffEditor.insertedTextBorder and diffEditor.removedTextBorder colors offsets changed lines in the diff editor by a few pixels. Since the colors have an alpha value of zero and aren't visible anyway, this PR removes them from all theme files.

Before:
gruvbox-issue

After:
gruvbox-fixed

Fixes #34.

@jdinhify
Copy link
Owner

jdinhify commented Sep 4, 2021

Thank you @klaussner

Are you comfortable adding yourself to the contributor list in package.json & README.md?

@klaussner
Copy link
Contributor Author

Sure! I've added myself to the list in 1e41a71.

@jdinhify jdinhify merged commit 4e4d470 into jdinhify:main Sep 4, 2021
github-actions bot pushed a commit that referenced this pull request Sep 5, 2021
## [1.5.1](v1.5.0...v1.5.1) (2021-09-05)

### Bug Fixes

* 🐛 remove text borders in diff editor ([#42](#42)) ([4e4d470](4e4d470))
@jdinhify
Copy link
Owner

jdinhify commented Sep 5, 2021

🎉 This PR is included in version 1.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diff view lines mis-aligned
2 participants