TypePolicies #32
TypePolicies #32
Conversation
| let cache = | ||
| ApolloClient.Cache.InMemoryCache.( | ||
| make( | ||
| ~typePolicies=[| |
There was a problem hiding this comment.
Why not work with objects and have a more 1:1 binding?
There was a problem hiding this comment.
I just didn't see any way to express the types with objects at all besides doing Js.t('anything). This uses Js.Dict.t under the hood. I opted to just forego requiring the user to Js.Dict.fromArray in favor of passing the array directly. Do you think it would be better to require an actual Js.Dict.t for clarity?
There was a problem hiding this comment.
One thing that stinks as well with this implementation is that you can't just choose to bypass that and use Js.t yourself because it is expecting specific variants to represent the unions in typescript. 🤷
There was a problem hiding this comment.
I think this is pretty nice actually!
@jfrolich Here's some proper
TypePolicies.tand pagination helpers. It all turned out rather less elegant than I would have liked. Rather than go into detail, I thought I'd see if you had any initial feedback.EXAMPLES/src/caching/Pagination.reshows the basic ergonomics