Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): unpin pyo3 #59

Merged
merged 1 commit into from
Feb 29, 2024
Merged

chore(deps): unpin pyo3 #59

merged 1 commit into from
Feb 29, 2024

Conversation

jeertmans
Copy link
Owner

Following suggestion from PyO3/maturin#1960 (comment)

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (6864349) to head (d19dded).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   89.10%   89.10%           
=======================================
  Files          14       14           
  Lines         404      404           
=======================================
  Hits          360      360           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Python benchmark results:


------------------------------------------------- benchmark: 12 tests --------------------------------------------------
Name (time in us)                                              Mean             StdDev            OPS (Kops/s)          
------------------------------------------------------------------------------------------------------------------------
test_generate_all_path_candidates[0-0] (0002_pgo)           98.0600 (1.03)     12.2385 (2.37)          10.1978 (0.97)   
test_generate_all_path_candidates[1-1] (0002_pgo)           94.9309 (1.0)       5.8175 (1.13)          10.5340 (1.0)    
test_generate_all_path_candidates[0-0] (0003_before)        96.9318 (1.02)      8.2247 (1.59)          10.3165 (0.98)   
test_generate_all_path_candidates[0-0] (0001_changes)       95.7184 (1.01)      7.9538 (1.54)          10.4473 (0.99)   
test_generate_all_path_candidates[1-1] (0001_changes)       95.7355 (1.01)      5.1702 (1.0)           10.4454 (0.99)   
test_generate_all_path_candidates[1-1] (0003_before)        97.1001 (1.02)      6.0336 (1.17)          10.2987 (0.98)   
test_generate_all_path_candidates[4-5] (0002_pgo)          106.1854 (1.12)      6.4361 (1.24)           9.4175 (0.89)   
test_generate_all_path_candidates[4-5] (0003_before)       107.6675 (1.13)      6.7263 (1.30)           9.2879 (0.88)   
test_generate_all_path_candidates[4-5] (0001_changes)      106.6067 (1.12)      5.3330 (1.03)           9.3803 (0.89)   
test_generate_all_path_candidates[10-3] (0002_pgo)         118.2173 (1.25)      6.3860 (1.24)           8.4590 (0.80)   
test_generate_all_path_candidates[10-3] (0003_before)      117.9528 (1.24)      6.5416 (1.27)           8.4780 (0.80)   
test_generate_all_path_candidates[10-3] (0001_changes)     118.8766 (1.25)      8.9083 (1.72)           8.4121 (0.80)   
------------------------------------------------------------------------------------------------------------------------

-------------------------------- benchmark 'complete_graph_all_paths': 3 tests --------------------------------
Name (time in ns)                                    Mean              StdDev            OPS (Mops/s)          
---------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths (0003_before)      367.1577 (1.09)     610.9904 (21.39)          2.7236 (0.92)   
test_complete_graph_all_paths (0001_changes)     381.6699 (1.13)     113.5032 (3.97)           2.6201 (0.89)   
test_complete_graph_all_paths (0002_pgo)         338.0116 (1.0)       28.5687 (1.0)            2.9585 (1.0)    
---------------------------------------------------------------------------------------------------------------

---------------------------------- benchmark 'complete_graph_all_paths_array_chunks': 12 tests -----------------------------------
Name (time in ns)                                                       Mean              StdDev            OPS (Mops/s)          
----------------------------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths_array_chunks[1000] (0002_pgo)          28.7602 (1.0)      200.8515 (1.71)          34.7702 (1.0)    
test_complete_graph_all_paths_array_chunks[1000] (0003_before)       30.5176 (1.06)     129.4021 (1.10)          32.7680 (0.94)   
test_complete_graph_all_paths_array_chunks[1000] (0001_changes)      30.8100 (1.07)     134.4373 (1.15)          32.4570 (0.93)   
test_complete_graph_all_paths_array_chunks[100] (0002_pgo)           36.1990 (1.26)     117.2067 (1.0)           27.6251 (0.79)   
test_complete_graph_all_paths_array_chunks[100] (0001_changes)       39.7488 (1.38)     173.5634 (1.48)          25.1580 (0.72)   
test_complete_graph_all_paths_array_chunks[100] (0003_before)        40.2594 (1.40)     285.6288 (2.44)          24.8389 (0.71)   
test_complete_graph_all_paths_array_chunks[10] (0002_pgo)            72.7886 (2.53)     217.5096 (1.86)          13.7384 (0.40)   
test_complete_graph_all_paths_array_chunks[10] (0001_changes)        76.0577 (2.64)     250.8640 (2.14)          13.1479 (0.38)   
test_complete_graph_all_paths_array_chunks[10] (0003_before)         76.4530 (2.66)     229.4411 (1.96)          13.0799 (0.38)   
test_complete_graph_all_paths_array_chunks[1] (0002_pgo)            327.5906 (11.39)    529.3159 (4.52)           3.0526 (0.09)   
test_complete_graph_all_paths_array_chunks[1] (0001_changes)        335.2879 (11.66)    999.3338 (8.53)           2.9825 (0.09)   
test_complete_graph_all_paths_array_chunks[1] (0003_before)         333.9033 (11.61)    647.1584 (5.52)           2.9949 (0.09)   
----------------------------------------------------------------------------------------------------------------------------------

------------------------------------- benchmark 'di_graph_complete_graph_all_paths_array_chunks': 12 tests -------------------------------------
Name (time in ns)                                                                     Mean              StdDev            OPS (Mops/s)          
------------------------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0002_pgo)         231.0287 (1.0)        8.6486 (1.06)           4.3285 (1.0)    
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0002_pgo)          248.0302 (1.07)      22.3639 (2.75)           4.0318 (0.93)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0003_before)      244.9911 (1.06)       8.1358 (1.0)            4.0818 (0.94)   
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0001_changes)      266.7252 (1.15)      23.8081 (2.93)           3.7492 (0.87)   
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0003_before)       267.1993 (1.16)      24.3893 (3.00)           3.7425 (0.86)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0001_changes)     247.3363 (1.07)      10.5266 (1.29)           4.0431 (0.93)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0002_pgo)           308.7598 (1.34)     100.6034 (12.37)          3.2388 (0.75)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0001_changes)       329.2673 (1.43)     110.4129 (13.57)          3.0370 (0.70)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0003_before)        329.7403 (1.43)      83.2108 (10.23)          3.0327 (0.70)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0002_pgo)            662.5283 (2.87)     573.8763 (70.54)          1.5094 (0.35)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0001_changes)        676.5125 (2.93)     468.3218 (57.56)          1.4782 (0.34)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0003_before)         704.0035 (3.05)     793.8637 (97.58)          1.4204 (0.33)   
------------------------------------------------------------------------------------------------------------------------------------------------

-------------------------------- benchmark 'di_graph_from_complete_graph_all_paths': 3 tests --------------------------------
Name (time in ns)                                                  Mean              StdDev            OPS (Mops/s)          
-----------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths (0002_pgo)         617.5330 (1.0)      576.6358 (1.0)            1.6193 (1.0)    
test_di_graph_from_complete_graph_all_paths (0001_changes)     658.4915 (1.07)     587.1213 (1.02)           1.5186 (0.94)   
test_di_graph_from_complete_graph_all_paths (0003_before)      679.3215 (1.10)     808.2183 (1.40)           1.4721 (0.91)   
-----------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

Copy link
Contributor

Rust benchmark results:

group                                                       before                                 changes
-----                                                       ------                                 -------
complete_graph_all_paths/iter                               1.01     23.4±0.65ns 40.8 MElem/sec    1.00     23.2±0.16ns 41.1 MElem/sec
complete_graph_all_paths_array_chunks/1                     1.00     32.6±0.16ns 29.3 MElem/sec    1.01     33.0±0.55ns 28.9 MElem/sec
complete_graph_all_paths_array_chunks/10                    1.00    356.3±3.79ns 26.8 MElem/sec    1.08    383.8±2.76ns 24.8 MElem/sec
complete_graph_all_paths_array_chunks/100                   1.00      2.6±0.04µs 37.2 MElem/sec    1.00      2.5±0.02µs 37.4 MElem/sec
complete_graph_all_paths_array_chunks/1000                  1.00     22.5±0.18µs 42.4 MElem/sec    1.05     23.6±0.41µs 40.4 MElem/sec
di_graph_from_complete_graph_all_paths/iter                 1.00    237.0±3.03ns  4.0 MElem/sec    1.00    236.6±1.54ns  4.0 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1       1.00    237.7±1.77ns  4.0 MElem/sec    1.03    245.1±2.51ns  3.9 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/10      1.00      2.6±0.05µs  3.6 MElem/sec    1.00      2.6±0.16µs  3.6 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/100     1.00     26.0±0.16µs  3.7 MElem/sec    1.01     26.1±0.20µs  3.6 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1000    1.00    248.3±1.85µs  3.8 MElem/sec    1.00    249.2±2.36µs  3.8 MElem/sec

@jeertmans jeertmans merged commit 9ef9ddb into main Feb 29, 2024
45 checks passed
@jeertmans jeertmans deleted the deps-pyo3 branch February 29, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant