Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] replaying last slide only play one animation #161

Closed
jeertmans opened this issue Mar 20, 2023 · 0 comments · Fixed by #162
Closed

[BUG] replaying last slide only play one animation #161

jeertmans opened this issue Mar 20, 2023 · 0 comments · Fixed by #162
Labels
bug Something isn't working present Related to the main "present" feature

Comments

@jeertmans
Copy link
Owner

Description

When reversing or replaying the last slide, only one animation is played.

Version

4.10.0

Platform

All

Screenshots

No response

Additional information

No response
@jeertmans jeertmans added bug Something isn't working present Related to the main "present" feature labels Mar 20, 2023
@jeertmans jeertmans mentioned this issue Mar 20, 2023
Merged
jeertmans added a commit that referenced this issue Mar 20, 2023
@jeertmans
fix(cli): do not terminate slides early
712023d 
When a slide is replayed (either normally or reversed), its state must be reset.

Closes #161
jeertmans added a commit that referenced this issue Mar 20, 2023
@jeertmans @pre-commit-ci
fix(cli): do not terminate slides early (#162)
8c578d2 
* fix(cli): do not terminate slides early

When a slide is replayed (either normally or reversed), its state must be reset.

Closes #161

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@ccoors ccoors mentioned this issue Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working present Related to the main "present" feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): do not terminate slides early jeertmans/manim-slides
1 participant
@jeertmans