Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Loop example does not match API #307

Closed
cogan-shimizu opened this issue Nov 12, 2023 · 1 comment
Closed

[DOC] Loop example does not match API #307

cogan-shimizu opened this issue Nov 12, 2023 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation wontfix This will not be worked on

Comments

@cogan-shimizu
Copy link

Describe the Issue

The start_loop and end_loop are still used in the example on the front page, but according to the changelog for v5, this was a breaking change (#294).

Definitely made for an interesting hiccup in starting out ;)

Affected Page

https://www.manim.community/plugin/manim-slides/

Issue Type

Documentation Enhancement

Recommended fix or suggestions

        self.next_slide(loop=True)  # Waits user to press continue to go to the next slide

        self.play(MoveAlongPath(dot, circle), run_time=2, rate_func=linear)
        self.next_slide()

or something similar, not sure if that's the exact practice -- but it compiles and presents!

@cogan-shimizu cogan-shimizu added the bug Something isn't working label Nov 12, 2023
@jeertmans jeertmans added the wontfix This will not be worked on label Nov 13, 2023
@jeertmans
Copy link
Owner

Hello @cogan-shimizu, thanks for reaching out!

Actually, this isn't a "Manim Slides" issues, but an issue from the Manim Community Plugin site that is not updated correctly.

The documentation from Manim Slides is up-to-date, see: https://github.com/jeertmans/manim-slides. In general, you should refer to this page and my website for the docs.

The page you linked is actually scraped from PyPI, but does not seem to be up-to-date.
Sadly, I cannot do anything about that, because I do not own Manim plugins :/

@jeertmans jeertmans closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2024
@jeertmans jeertmans added the documentation Improvements or additions to documentation label Apr 4, 2024
@jeertmans jeertmans changed the title DOC: example does not match API [DOC] Loop example does not match API Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants