Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lib): add loop option to next_slide and remove start/end_loop #294

Merged
merged 2 commits into from
Oct 19, 2023
Merged

feat(lib): add loop option to next_slide and remove start/end_loop #294

merged 2 commits into from
Oct 19, 2023

Conversation

jeertmans
Copy link
Owner

No description provided.

@jeertmans jeertmans added the lib Related to the library (a.k.a. module) label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Files Coverage Δ
manim_slides/__init__.py 60.00% <100.00%> (ø)
manim_slides/__main__.py 71.42% <100.00%> (-0.67%) ⬇️
manim_slides/commons.py 96.15% <ø> (ø)
manim_slides/config.py 82.75% <100.00%> (-1.16%) ⬇️
manim_slides/logger.py 100.00% <100.00%> (ø)
manim_slides/present/player.py 76.62% <100.00%> (ø)
manim_slides/slide/manimlib.py 100.00% <100.00%> (ø)
manim_slides/slide/animation.py 97.56% <97.56%> (ø)
manim_slides/utils.py 89.74% <83.33%> (-2.15%) ⬇️
manim_slides/convert.py 87.63% <72.72%> (+13.44%) ⬆️
... and 6 more

📢 Thoughts on this report? Let us know!.

@jeertmans jeertmans merged commit 0322dae into main Oct 19, 2023
19 of 20 checks passed
@jeertmans jeertmans deleted the next-slide-loop branch October 19, 2023 13:37
@jeertmans jeertmans linked an issue Oct 20, 2023 that may be closed by this pull request
[FEATURE] make self.start_loop call self.next_slide #266
Closed
@jeertmans jeertmans mentioned this pull request Oct 20, 2023
Closed
@cogan-shimizu cogan-shimizu mentioned this pull request Nov 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lib Related to the library (a.k.a. module)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] make self.start_loop call self.next_slide
1 participant
@jeertmans