Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci/deps): publish wheels and add manim/manimgl as extras #173

Merged
merged 8 commits into from
May 7, 2023

Conversation

jeertmans
Copy link
Owner

@jeertmans jeertmans commented May 1, 2023

Hello @bryanwweber, here is a first PR to address #170.
Would you mind reviewing this?

As proposed, I added manim and manimgl extras, so they can now be installed directly with manim-slides. I will document this new feature as part of another PR, that will address #169.

In addition, I think you should provide a wheel package on PyPI.

Well go catch for this one! I didn't even notice I was not building wheels, but that should now be the case in future releases.

I also suggest that you specify the compatible python_requires (or the equivalent poetry setting).

This is what this line is for:

python = ">=3.8.1,<3.12"

I suggest setting this as a lower bound and not an upper bound...

I don't think discarding the upper bound will work. This is because packages that Manim Slides depends on have set some upper bound. So Poetry will complain about that if you do not set an upper bound that matches the one of its dependencies. Hopefully, this will never be a limitation, as packages will update their upper bound as soon as new Python versions are released.

Closes #170

@jeertmans jeertmans added ci Continous Integration (tests, lints, checks, ...) dependencies Pull requests that update a dependency file labels May 1, 2023
@pre-commit-ci pre-commit-ci bot temporarily deployed to github-pages May 1, 2023 09:36 Inactive
@jeertmans jeertmans temporarily deployed to github-pages May 1, 2023 10:06 — with GitHub Actions Inactive
@jeertmans jeertmans temporarily deployed to github-pages May 7, 2023 18:30 — with GitHub Actions Inactive
@jeertmans jeertmans merged commit fce9546 into main May 7, 2023
@jeertmans jeertmans deleted the manim-extras branch May 7, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continous Integration (tests, lints, checks, ...) dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add wheel to PyPI and declare dependencies on Manim/ManimGL
2 participants