Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): check if reversed file exist #231

Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix(lib): check if reversed file exist #231

merged 1 commit into from
Aug 2, 2023

Conversation

jeertmans
Copy link
Owner

This fixes a bug that would block the process forever because FFMPEG was asking if it could overwrite or not.

This fixes a bug that would block the process forever because FFMPEG was asking if it could overwrite or not.
@jeertmans jeertmans added bug Something isn't working lib Related to the library (a.k.a. module) labels Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (98fa534) 58.36% compared to head (01fe137) 58.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   58.36%   58.33%   -0.04%     
==========================================
  Files          14       14              
  Lines        1715     1716       +1     
==========================================
  Hits         1001     1001              
- Misses        714      715       +1     
Files Changed Coverage Δ
manim_slides/slide.py 49.18% <0.00%> (-0.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeertmans jeertmans merged commit 1e96789 into main Aug 2, 2023
20 of 23 checks passed
@jeertmans jeertmans deleted the fix-reverse branch August 2, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lib Related to the library (a.k.a. module)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant