Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): rewrite FSM and patch multiple presentation bugs #234

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

jeertmans
Copy link
Owner

I small rewrite of the Finite State Machine was needed to fix a lot of issues when transitioning from one presentation to another.

Here are a few:

  • loading last slide from previous presentation would actually load the second last;
  • if the first animation of some presentation was played in reverse, then going to the previous presentation, then back to the current, would play the first slide in reverse again
  • no pause was performed between two presentation, this is now automatic

@jeertmans jeertmans added bug Something isn't working enhancement New feature or request lib Related to the library (a.k.a. module) labels Aug 4, 2023
@jeertmans jeertmans temporarily deployed to github-pages August 4, 2023 14:08 — with GitHub Actions Inactive
@jeertmans jeertmans linked an issue Aug 4, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 27.27% and project coverage change: +0.24% 🎉

Comparison is base (9e1e0f2) 59.11% compared to head (e1ac428) 59.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   59.11%   59.35%   +0.24%     
==========================================
  Files          14       14              
  Lines        1734     1737       +3     
==========================================
+ Hits         1025     1031       +6     
+ Misses        709      706       -3     
Files Changed Coverage Δ
manim_slides/present.py 57.35% <27.27%> (+0.71%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeertmans jeertmans merged commit 455f104 into main Aug 4, 2023
23 of 25 checks passed
@jeertmans jeertmans deleted the fix-reversed branch August 4, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request lib Related to the library (a.k.a. module)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] manim-slides gets confused with multiple scenes
1 participant