-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): add tests for converter methods #283
Merged
jeertmans
merged 5 commits into
jeertmans:main
from
taiyeoguns:feature/277-tests-for-convert-methods
Oct 17, 2023
Merged
chore(tests): add tests for converter methods #283
jeertmans
merged 5 commits into
jeertmans:main
from
taiyeoguns:feature/277-tests-for-convert-methods
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiyeoguns
temporarily deployed
to
github-pages
October 9, 2023 10:38
— with
GitHub Actions
Inactive
jeertmans
added
the
hacktoberfest-accepted
PR accepted as contribution taking part to the hacktoberfest
label
Oct 13, 2023
Thanks for your PR @taiyeoguns! I'll review and merge this once I have some time :-) |
jeertmans
had a problem deploying
to
github-pages
October 17, 2023 14:40
— with
GitHub Actions
Error
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
jeertmans
had a problem deploying
to
github-pages
October 17, 2023 14:51
— with
GitHub Actions
Error
jeertmans
requested changes
Oct 17, 2023
jeertmans
temporarily deployed
to
github-pages
October 17, 2023 14:59
— with
GitHub Actions
Inactive
taiyeoguns
temporarily deployed
to
github-pages
October 17, 2023 18:21
— with
GitHub Actions
Inactive
Looks good to me, thanks @taiyeoguns! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Resolves #277
Description
Adds tests for convert methods
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers