Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): add tests for converter methods #283

Merged

Conversation

taiyeoguns
Copy link
Contributor

Fixes Issue

Resolves #277

Description

Adds tests for convert methods

Check List (Check all the applicable boxes)

  • I understand that my contributions needs to pass the checks.
  • If I created new functions / methods, I documented them and add type hints.
  • If I modified already existing code, I updated the documentation accordingly.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@taiyeoguns taiyeoguns temporarily deployed to github-pages October 9, 2023 10:38 — with GitHub Actions Inactive
@jeertmans jeertmans added the hacktoberfest-accepted PR accepted as contribution taking part to the hacktoberfest label Oct 13, 2023
@jeertmans
Copy link
Owner

Thanks for your PR @taiyeoguns! I'll review and merge this once I have some time :-)

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Files Coverage Δ
manim_slides/__main__.py 71.42% <100.00%> (-0.67%) ⬇️
manim_slides/config.py 83.91% <ø> (ø)
manim_slides/docs/manim_slides_directive.py 0.00% <ø> (ø)
manim_slides/logger.py 100.00% <100.00%> (ø)
manim_slides/slide/manimlib.py 100.00% <100.00%> (ø)
manim_slides/wizard.py 37.39% <ø> (ø)
manim_slides/convert.py 87.50% <66.66%> (+13.31%) ⬆️
manim_slides/slide/animation.py 96.55% <96.55%> (ø)
manim_slides/utils.py 89.74% <83.33%> (-2.15%) ⬇️
manim_slides/slide/manim.py 93.47% <93.47%> (ø)
... and 2 more

📢 Thoughts on this report? Let us know!.

tests/test_convert.py Outdated Show resolved Hide resolved
@jeertmans jeertmans temporarily deployed to github-pages October 17, 2023 14:59 — with GitHub Actions Inactive
@taiyeoguns taiyeoguns temporarily deployed to github-pages October 17, 2023 18:21 — with GitHub Actions Inactive
@jeertmans
Copy link
Owner

Looks good to me, thanks @taiyeoguns!

@jeertmans jeertmans merged commit 860ab23 into jeertmans:main Oct 17, 2023
14 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PR accepted as contribution taking part to the hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TEST] Write tests for convert methods
2 participants