Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lib): enhance notes support #324

Merged
merged 6 commits into from
Nov 28, 2023
Merged

feat(lib): enhance notes support #324

merged 6 commits into from
Nov 28, 2023

Conversation

jeertmans
Copy link
Owner

@jeertmans jeertmans commented Nov 24, 2023 •
edited
Loading

This PR adds a new experimental presenter view that features useful information for presenting content on two screens.

image

@jeertmans jeertmans added the enhancement New feature or request label Nov 24, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 24, 2023 •
edited
Loading

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (dc58d49) 80.00% compared to head (8174b1c) 80.17%.
Report is 1 commits behind head on main.

Files Patch % Lines
manim_slides/present/player.py 86.27% 14 Missing ⚠️
manim_slides/convert.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   80.00%   80.17%   +0.17%     
==========================================
  Files          21       21              
  Lines        1690     1781      +91     
==========================================
+ Hits         1352     1428      +76     
- Misses        338      353      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeertmans jeertmans linked an issue Nov 27, 2023 that may be closed by this pull request
[FEATURE] enhance notes #323
Closed
@jeertmans jeertmans added the present Related to the main "present" feature label Nov 28, 2023
@jeertmans jeertmans linked an issue Nov 28, 2023 that may be closed by this pull request
[FEATURE] Speaker Notes section #311
Closed
@jeertmans jeertmans merged commit 050ee0a into main Nov 28, 2023
20 of 22 checks passed
@jeertmans jeertmans deleted the enhance-notes branch November 28, 2023 14:15
@jeertmans jeertmans mentioned this pull request Nov 28, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request present Related to the main "present" feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] enhance notes [FEATURE] Speaker Notes section
1 participant
@jeertmans