Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): pre-commit mypy #41

Merged
merged 12 commits into from
Oct 11, 2022
Merged

chore(ci): pre-commit mypy #41

merged 12 commits into from
Oct 11, 2022

Conversation

elliotwutingfeng
Copy link
Contributor

Addresses #37


Need feedback on which mypy arguments are relevant.

@jeertmans
Copy link
Owner

Hi @elliotwutingfeng, great work, thanks!

Reviewing your contribution will take some time, as I need to understand why mypy doesn't find stubs for packages that should have stubs.

I will reach back to you asap ;-)

@jeertmans jeertmans added the hacktoberfest-accepted PR accepted as contribution taking part to the hacktoberfest label Oct 11, 2022
@jeertmans
Copy link
Owner

Well, I think it's fine to merge this now @elliotwutingfeng
Making mypy happy is a long term goal, so I won't bother having some errors for now.

Thanks!

@jeertmans jeertmans merged commit 5b9cb15 into jeertmans:main Oct 11, 2022
@jeertmans jeertmans linked an issue Oct 11, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PR accepted as contribution taking part to the hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TEST] Enforce type hints with MyPy
2 participants