Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib): Remove old validation check preventing loop=True with auto_next=True #445

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

mateuszdrwal
Copy link
Contributor

Description

#299 added support for stopping looping slides smoothly, at which point specifying both loop=True and auto_next=True on a next_slide starts making sense. There is an old validation check in the code referencing #299 that was never removed.

This functionality (on the next press, waiting for the current loop to end and then immediately proceeding to the next slide) seems to work without issues on the QT presenter. The reveal.js presenter doesn't like it as much, but it's also not supported by --next-terminates-loop.

Check List (Check all the applicable boxes)

  • I understand that my contributions needs to pass the checks.
  • If I created new functions / methods, I documented them and add type hints.
  • If I modified already existing code, I updated the documentation accordingly.
  • The title of my pull request is a short description of the requested changes.

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.24%. Comparing base (9460f6b) to head (9f1d27d).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
- Coverage   79.30%   79.24%   -0.07%     
==========================================
  Files          22       22              
  Lines        1822     1816       -6     
==========================================
- Hits         1445     1439       -6     
  Misses        377      377              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeertmans
Copy link
Owner

Looks great, thanks!

@jeertmans jeertmans changed the title Remove old validation check preventing loop=True with auto_next=True chore(lib): Remove old validation check preventing loop=True with auto_next=True Jun 2, 2024
@jeertmans
Copy link
Owner

Would you mind adding an entry to the CHANGELOG file?

@mateuszdrwal
Copy link
Contributor Author

Yep, there you go

@jeertmans
Copy link
Owner

Yep, there you go

Many thanks!!

@jeertmans jeertmans merged commit 0aa624c into jeertmans:main Jun 2, 2024
13 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants