-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(present): black video flashes and other bugs linked to Qt #465
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 80.54% 77.83% -2.72%
==========================================
Files 22 22
Lines 1835 1827 -8
==========================================
- Hits 1478 1422 -56
- Misses 357 405 +48 ☔ View full report in Codecov by Sentry. |
@PeculiarProgrammer: did you check that #315 was fixed on Windows? |
Yep. #315 was fixed. |
Thanks @PeculiarProgrammer, I also ran some tests on Windows, both with PySide6 and PyQt6, and it worked (for PyQt6, I had to bump the minimal version, but looks good). |
See #464 for original pull request. I did some mistakes but by pushing on my main branch instead of @PeculiarProgrammer 's main branch.