Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue more templates #54

Merged
merged 7 commits into from
Oct 19, 2022
Merged

Issue more templates #54

merged 7 commits into from
Oct 19, 2022

Conversation

harisaisundhar
Copy link
Contributor

@harisaisundhar harisaisundhar commented Oct 19, 2022

Description

  • Template drafted for documentation
  • Consists of attributes for describing the issue, link to affected page, Issue type, Recommendation
  • Code of conduct is also added, can keep or remove them subjected to approval

Check List (Check all the applicable boxes)

  • I understand that my contributions needs to pass the checks.
  • If I created new functions / methods, I documented them and add type hints.
  • If I modified already existing code, I updated the documentation accordingly.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2022-10-19 at 8 13 59 PM

Note to reviewers

Template for Question/Help/Support is put on hold until further clarification.

Questions :

  1. Should we redirect them to a support page or design a template like the other issues ?
  2. If questions based template is to be used, what is the plan to revert back to the user ?

@harisaisundhar
Copy link
Contributor Author

Closes #42

@jeertmans
Copy link
Owner

Thank you for your work @harisaisundhar!
You mention a code a conduct, but I see none: is it normal?

@harisaisundhar
Copy link
Contributor Author

Thank you for your work @harisaisundhar! You mention a code a conduct, but I see none: is it normal?

Uh no! I am not aware if we have a document in place. Can remove it otherwise. Also do let me know about the Question/Help/Support, are we planning on raising an issue for that too ?

@jeertmans
Copy link
Owner

@harisaisundhar You can delete the code of conduct section for now, it will be added later if needed :)

You can create a separate PR for the Question/Help/Support template and link to the same issue #42

@harisaisundhar
Copy link
Contributor Author

Sure!

@harisaisundhar
Copy link
Contributor Author

Made the changes. Looks like build is failing from a different issue.

@jeertmans
Copy link
Owner

Don’t worry about pre commit, that’s not a problem :)

thanks for you work! Merging this soon!

@jeertmans jeertmans merged commit 2f8f756 into jeertmans:main Oct 19, 2022
@jeertmans jeertmans added the hacktoberfest-accepted PR accepted as contribution taking part to the hacktoberfest label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PR accepted as contribution taking part to the hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants