Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class inheritance highlighter gets confused by macros and comments #121

Closed
zrax opened this issue Apr 23, 2019 · 4 comments
Closed

class inheritance highlighter gets confused by macros and comments #121

zrax opened this issue Apr 23, 2019 · 4 comments
Labels
🐛 Bug Something isn't working Hard

Comments

@zrax
Copy link

zrax commented Apr 23, 2019

If a comment or macro exists anywhere after the class keyword and before the last parent class, the highlighting of parent classes and access specifiers is lost.

Examples:
image

@jeff-hykin jeff-hykin added Hard 🔍 investigating More information is being gathered labels Apr 23, 2019
@matter123
Copy link
Collaborator

With the first pattern, the grammar has no way of knowing that DLLEXPORT is actually __declspec(dllexport). class __declspec(dllexport) ChildClass should be highlighted correctly, however.

@MonaTheMonad
Copy link

The alignas specifier also seems to break highlighting in a similar manner.

@jeff-hykin jeff-hykin added the 🐛 Bug Something isn't working label Apr 24, 2019
@matter123
Copy link
Collaborator

The comment is fixed in 1.8.9.

@jeff-hykin
Copy link
Owner

Screen Shot 2019-06-24 at 6 40 24 PM

Alignas is fixed. `DLLEXPORT` isn't fixed, but it doesn't cause a cascading break anymore. Since DLLEXPORT isn't a built in I don't plan to support it directly. OS/Library specific things (within textmate) would be a best fixed by a grammar injection extension so that people can toggle it on and off.

@matter123 matter123 removed the 🔍 investigating More information is being gathered label Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working Hard
Projects
None yet
Development

No branches or pull requests

4 participants