Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alignas as an attribute type #126

Closed
wants to merge 1 commit into from
Closed

add alignas as an attribute type #126

wants to merge 1 commit into from

Conversation

matter123
Copy link
Collaborator

@matter123 matter123 commented Apr 24, 2019

This fixes the alignas issue reported at #121 (comment).

There should probably be a refactor of inline_attribute soonish to support, support attributes like PACKED or DLLEXPORT

@jeff-hykin
Copy link
Owner

Are spaces allowed in __declspec(? like __declspec (

@matter123
Copy link
Collaborator Author

Looks like yes https://godbolt.org/z/NqM5by

@jeff-hykin
Copy link
Owner

okay, then I think we should take it out of the representation, or we should make the representation a regex that matches it. I'll try to find the best way to incorporate that for the other similar things too.

I think it might be best to remove the ()'s from the representation, and then just have the function-like adjective to indicate that it needs ()'s in the pattern

@matter123
Copy link
Collaborator Author

matter123 commented May 4, 2019

Ok, the concern is with __attribute__(( as it has double parenthesis on both sides. e.g. __attribute__((noreturn)) or __attribute((constructor(101)))

Edit: __attribute__ and __attribute allow spaces between them and (( as well.

@jeff-hykin
Copy link
Owner

I went ahead an manually merged this in just now. I moved them out of tokens though so that we can change them to include spaces in the future.

@jeff-hykin jeff-hykin closed this May 17, 2019
@matter123 matter123 deleted the Fix-Alignas branch July 18, 2019 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants