Parameter names are not highlighted

[arzaidi]

I have just started using Visual Studio Code, and installed your extension but it doesn't change anything in C++ syntax highlighting.
I am using Visual Studio Code - Insiders Version : 1.34.20

Attaching snapshot where you can see that the parameter type and name colors are unchanged.

[matter123]

Vscode insiders is already using 1.8.8 so there should be only minor improvements at the moment. Though that might be a bug.

[matter123]

Parameters type highlighting is being tracker by #135. We hope to get that merged in tonight.

[matter123]

Is what still white after disabling "Custom C++ Highlighting" and reloading?

[jeff-hykin]

@arzaidi The extension is the bleeding edge updates to the syntax, kind of like Chrome Canary, or Firefox nightlies. Sometimes there will be a big difference, however VS Code uses the extension to get official updates to the syntax once it the changes have proven to be stable.

As matter123 pointed out, right now there are not that many differences between the VS Code Insiders release and the Better C++ extension. If you're using the normal VS Code release though its quiet different.

[jeff-hykin]

You might also need a theme that highlights more pieces of the syntax, since the default VS Code theme highlights very little.

[matter123]

Yeah, the Dark (Visual Studio) theme does not have coloring for variable.parameter.

With Dark + (default dark) you can see that what and throwExcp are highlighted.

Closing as this is a theme color issue. See #7 if you want to customize your theme.

[arzaidi]

Thanks guys. I think there is some other issue here, as when I inspect, my variables are not marked as variables. I assume some different tokenization related extension needed?

[matter123]

Huh

[matter123]

Is that the whole file?

[arzaidi]

no thats not the whole file, it has usual includes and namespace etc on the top

[jeff-hykin]

If you can link the whole file we'll take a look into it. This is a pretty suprising bug.

[matter123]

It is marked as meta.function-call, are you defining a function while inside a function?

[arzaidi]

Found the root cause, it is due to the use of unnamed namespace. If you provide a name to the namespace then it works fine. Here is the sample to reproduce:

#include "sample.h"
namespace
{
void failedToLoadCriticalData(const string& what, bool throwExcp = false)
{
}
}

[matter123]

Probably the same issue/root cause as #72 then. Thanks.

[matter123]

@arzaidi
I meant that This and #72 had the same root cause, where the opening pattern expected a space then a {, not that is was exactly the same issue. If you want to test the fix for your issue #165 has its syntax file at https://raw.githubusercontent.com/jeff-hykin/cpp-textmate-grammar/fix/%23158/syntaxes/cpp.tmLanguage.json.

[arzaidi]

great. Thank you guys, I used this file and it fixed the issue.

[jeff-hykin]

I'll try to get matter123's merged into master in the next 2 days.