Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

universal-charcter-names not allowed in identifiers #17

Closed
matter123 opened this issue Mar 12, 2019 · 3 comments
Closed

universal-charcter-names not allowed in identifiers #17

matter123 opened this issue Mar 12, 2019 · 3 comments
Assignees
@jeff-hykin
Labels
🐛 Bug Something isn't working low priority

Comments

@matter123
Copy link
Collaborator

According to the standard identifiers are allowed to contain universal-character-names ([lex.name]/1).
Universal-character-names are of the the pattern /\\u[0-9a-fA-F]{4}/ or /\\U[0-9a-fA-F{8}/. When these characters are inserted into a place where identifiers are expected highlighting breaks.

Screenshot from 2019-03-12 11-14-12
@jeff-hykin jeff-hykin self-assigned this Mar 12, 2019
@jeff-hykin
Copy link
Owner

If that syntax is truly allowed everywhere its going to take awhile to get it tracked down.

The good news is a lot of the code already depends on variable_name or variable_name_without_bounds, once all of the legacy syntax is moved to using variable_name or variable_name_without_bounds this issue can be fixed pretty easily.

@jeff-hykin jeff-hykin added Nearly Impossible :( Things that likely need more than just Textmate matching to fix low priority 🐛 Bug Something isn't working and removed Nearly Impossible :( Things that likely need more than just Textmate matching to fix labels Mar 12, 2019
This was referenced Apr 10, 2019
Merged
Closed
jeff-hykin added a commit that referenced this issue Apr 11, 2019
@jeff-hykin
Merge branch 'master' into Fix-#17
6173f11
@jeff-hykin
Copy link
Owner

jeff-hykin commented Apr 11, 2019 •
edited
Loading

The merge for this broke things so I manually reverted.
Screen Shot 2019-04-10 at 8 33 52 PM

matter123 added a commit that referenced this issue Apr 11, 2019
@matter123
support for Universal Charcter Names #17
0bd47f4
jeff-hykin added a commit that referenced this issue Apr 14, 2019
@jeff-hykin
Merge branch 'master' into Fix-#17
3e41ba4
jeff-hykin added a commit that referenced this issue Apr 14, 2019
@jeff-hykin
support for Universal Charcter Names #17
2252a06 
support for Universal Charcter Names #17
@jeff-hykin
Copy link
Owner

pushed with v1.8.0

matter123 added a commit that referenced this issue May 11, 2019
@matter123
make functions support universal character sets #17
51b1203
@matter123 matter123 mentioned this issue May 11, 2019
Merged
jeff-hykin added a commit that referenced this issue May 15, 2019
@jeff-hykin
Merge branch 'Fix/#17-functions'
00e1812
@matter123 matter123 mentioned this issue May 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeff-hykin jeff-hykin

Labels
🐛 Bug Something isn't working low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matter123 @jeff-hykin