Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if constexpr causes incorrect syntax highlighting for rest of line #43

Closed
matter123 opened this issue Mar 22, 2019 · 2 comments
Closed
Labels
🐛 Bug Something isn't working

Comments

@matter123
Copy link
Collaborator

Example code

int main() {
      if constexpr(std::is_signed_v<char>>) { // no syntax highlighting
      }
}

The entirety of constexpr(std::is_signed_v<char>>) { // no syntax highlighting has the scope of meta.function-call.

Additionally, the developer tools console has the error [2] - Grammar is in an endless loop - Grammar pushed the same rule without advancing.

Neither the begin or end of the range pattern for "c_function_call" consume any characters. Per microsoft/vscode-textmate#12 VSCode has limited support for zero width range matches.

matter123 added a commit that referenced this issue Mar 23, 2019
This fixes:
 - if constexpr
 - asm volatile blocks
 - and operator()() function declerations
@jeff-hykin jeff-hykin added the 🐛 Bug Something isn't working label Mar 24, 2019
@jeff-hykin
Copy link
Owner

Currently I'm traveling, but as soon as I get back (next week) I'll go over the merge and push an update.

jeff-hykin added a commit that referenced this issue Mar 31, 2019
@jeff-hykin
Copy link
Owner

Screen Shot 2019-03-31 at 12 59 50 AM

Looks good.

Thats interesting about the endless loop, I've actually never looked at the developer console for the grammar 😅 I should probably start using that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants