Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enum bug: punctuation.inhertance.colon.cpp #55

Closed
peaceshi opened this issue Apr 6, 2019 · 8 comments
Closed

enum bug: punctuation.inhertance.colon.cpp #55

peaceshi opened this issue Apr 6, 2019 · 8 comments
Labels
🐛 Bug Something isn't working theme-color More related to theme than it is the syntax

Comments

@peaceshi
Copy link
Contributor

peaceshi commented Apr 6, 2019

set:
image
then
image
image

@matter123
Copy link
Collaborator

Can you provide some example code?

@peaceshi
Copy link
Contributor Author

peaceshi commented Apr 6, 2019

@matter123 matter123 added 🐛 Bug Something isn't working 🔍 investigating More information is being gathered labels Apr 6, 2019
@matter123
Copy link
Collaborator

matter123 commented Apr 7, 2019

well punctuation.inheritance.colon is probably better as punctuation.type-specifier.colon (@jeff-hykin ?).

I am not sure that the colon selected in the hover is an issue with this grammar. enum names are unscoped [decl.enum]/1. vscode-cpptools is doing something odd.

You can use the setting editor.tokenColorCustomizations to hide the issue, see #7 for more information.

@matter123 matter123 added the theme-color More related to theme than it is the syntax label Apr 7, 2019
@peaceshi
Copy link
Contributor Author

peaceshi commented Apr 7, 2019

well punctuation.inheritance.colon is probably better as punctuation.type-specifier.colon (@jeff-hykin ?).tokenColorCustomizations` to hide the issue, see #7 for more information.

I am not sure that the colon selected in the hover is an issue with this grammar. enum names are unscoped [decl.enum]/1. vscode-cpptools is doing something odd.

You can use the setting `editor.

yeah, just I use tokenColorCustomizations, then discover this intesting bug.

@matter123
Copy link
Collaborator

the slightly wrong scope is because #49 combined class,struct,enum and union all under one pattern, but enum uses the colon slightly differently.

matter123 added a commit that referenced this issue Apr 7, 2019
@matter123
Copy link
Collaborator

The scope should be more appropriate once #57 is accepted.

@jeff-hykin
Copy link
Owner

I think punctuation.type-specifier.colon is good name. I'll try to get that merged in by tonight.

@matter123 matter123 mentioned this issue Apr 8, 2019
@jeff-hykin
Copy link
Owner

This should be fixed by the next version, which should be pushed tonight. Let me know if it it's not fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working theme-color More related to theme than it is the syntax
Projects
None yet
Development

No branches or pull requests

3 participants