Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type alias #161

Merged
merged 7 commits into from
May 15, 2019
Merged

Add type alias #161

merged 7 commits into from
May 15, 2019

Conversation

matter123
Copy link
Collaborator

Adds a type_alias pattern and tests. Extracted from #135.

@jeff-hykin
Copy link
Owner

jeff-hykin commented May 11, 2019

If you can add some unit tests to :type_alias, I'll go ahead and merge it in. (I would do it, but I'm not sure exactly what is valid/invalid)

I still don't fully understand the :qualified_type pattern but I'll figure it out later

@matter123
Copy link
Collaborator Author

Sure.

@matter123
Copy link
Collaborator Author

The unit tests aren't quite sufficient yet

@matter123
Copy link
Collaborator Author

Ok, unit test added and all tests pass.

@matter123
Copy link
Collaborator Author

So :qualified_type is supposed to match a fully storage, namespace, and template qualified type.
that is struct A::B::C::D or std::enable_if<std::numeric_limit<long long int>::digits > 10, bool> It doesn't match type qualifiers like const or static or restrict, or type modifiers like ** and & so that it can be used in more places. The hope/plan is that much in the same way variable_name is used anywhere a name is expected, qualified_type is used whenever a type is expected.

@jeff-hykin jeff-hykin merged commit 7555c2d into master May 15, 2019
@matter123 matter123 deleted the Add/type-alias branch June 18, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants