Add destructor pattern #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some exit conditions can result in the underlying subprocess returning a staus code of 256. as kernel#exit only handles 1 byte https://bugs.ruby-lang.org/issues/8083 this causes the actual exit code to be 0
destructors are not allowed to take paramaters so a range is not needed. destructor_proptype was an unneeded pattern.
jeff-hykin
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
destructors are not allowed to take parameters so a range is not needed.
destructor_proptype was an unneeded pattern.
prevents matching foo::~bar() as a single function name. Instead, its matched as a scope resolution and ~foo()
Part of #80
The generate script was made to just return false on error. See the commit message for why.