Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Version +8.9.0 #33

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Node Version +8.9.0 #33

merged 1 commit into from
Nov 27, 2018

Conversation

sportnak
Copy link
Contributor

(Joi)[https://github.com/hapijs/joi/] decided to require node 8.9.0 to support Node TLS. I've run into this dependency breaking installing of wait-on in my build environment with node 6.

(Joi)[https://github.com/hapijs/joi/] decided to require node 8.9.0 to support Node TLS. I've run into this dependency breaking installing of wait-on in my build environment with node 6.
@kossnocorp
Copy link

Maybe instead it's better to stick to a particular joi version?

@sportnak
Copy link
Contributor Author

I think that's reasonable since this module doesn't depend on TLS as far as I can tell. Though parent projects will have a small gap in Node 6 support 😬. I came across this from the start-server-and-test module. I'd be happy to PR their documentation with the relevant support gaps though.

@sportnak
Copy link
Contributor Author

Here's where it last changed: https://github.com/jeffbski/wait-on/blame/fc9f8fbe88763c511b268d8878aa0ae7cb9790c9/package.json#L32. I'll see if I can find the latest version that still supports Node 6 though.

@sportnak
Copy link
Contributor Author

The latest version that supports Node 6 I believe is 11.4.0 based on https://github.com/hapijs/joi/blame/ba5f3c9866e33231fbc1336017f80ad3e9f202c7/package.json

@jeffbski
Copy link
Owner

@sportnak thanks for tracking this down and for making the pull request

@jeffbski jeffbski merged commit f45bcd5 into jeffbski:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants