v1.18: deprecate get_client and get_multi_client (backport of #177)…

… (#182) * deprecate `get_client` and `get_multi_client` (#177) deprecate get_client and get_multi_client (cherry picked from commit 00c984f) * bump deprecated version numbers --------- Co-authored-by: Greg Cusack <greg.cusack@anza.xyz>
jeffwashington · Mar 11, 2024 · 0804647 · 0804647
1 parent 1f79867
commit 0804647
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/bench-tps/src/main.rs b/bench-tps/src/main.rs
@@ -1,4 +1,5 @@
 #![allow(clippy::arithmetic_side_effects)]
+#![allow(deprecated)]
 use {
     clap::value_t,
     log::*,

diff --git a/dos/src/main.rs b/dos/src/main.rs
@@ -39,6 +39,7 @@
 //! ```
 //!
 #![allow(clippy::arithmetic_side_effects)]
+#![allow(deprecated)]
 use {
     crossbeam_channel::{select, tick, unbounded, Receiver, Sender},
     itertools::Itertools,

diff --git a/gossip/src/gossip_service.rs b/gossip/src/gossip_service.rs
@@ -193,6 +193,7 @@ pub fn discover(
 }
 
 /// Creates a ThinClient by selecting a valid node at random
+#[deprecated(since = "1.18.6", note = "Interface will change")]
 pub fn get_client(
     nodes: &[ContactInfo],
     socket_addr_space: &SocketAddrSpace,
@@ -208,6 +209,7 @@ pub fn get_client(
     ThinClient::new(rpc, tpu, connection_cache)
 }
 
+#[deprecated(since = "1.18.6", note = "Will be removed in favor of get_client")]
 pub fn get_multi_client(
     nodes: &[ContactInfo],
     socket_addr_space: &SocketAddrSpace,