Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making LSI evaluatable #144

Closed
ibnesayeed opened this issue Jan 21, 2017 · 3 comments
Closed

Making LSI evaluatable #144

ibnesayeed opened this issue Jan 21, 2017 · 3 comments

Comments

@ibnesayeed
Copy link
Contributor

As per the #142 implementation, in order to evaluate a classifier, the classifier instance needs to support a uniform interface of train, classify, categories and reset methods. I have recently added reset functionality to all classifiers #143 as it could be useful even when not evaluated.

Is it OK if I add train, classify, categories, and perhaps untrain method as well in the LSI while internally utilizing existing methods and not breaking any backwards compatibility?

As far as I understood LSI, in order to get the list of all known categories, I will have to scan all the indexed items. Is there any other faster way to get that information?

@Ch4s3
Copy link
Member

Ch4s3 commented Jan 23, 2017

Yeah that should be fine

@ibnesayeed
Copy link
Contributor Author

@Ch4s3: Yeah that should be fine

We will take care of it in a separate PR once #142 and #143 are merged.

@Ch4s3
Copy link
Member

Ch4s3 commented Feb 8, 2017

You should be good to go now. Sorry to keep you waiting.

@Ch4s3 Ch4s3 closed this as completed Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants