Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to reset trained classifiers to their initial state #143

Merged
merged 12 commits into from
Feb 8, 2017
Merged

Add support to reset trained classifiers to their initial state #143

merged 12 commits into from
Feb 8, 2017

Conversation

ibnesayeed
Copy link
Contributor

I was preserving stopwords to restore on test teardown. However, if the Redis connection fails then the old stopwords were not available to restore. Changing order so that stopwords are cached before Redis connection fails, solved the issue.

@ibnesayeed ibnesayeed closed this Jan 21, 2017
@ibnesayeed ibnesayeed reopened this Jan 21, 2017
@ibnesayeed ibnesayeed closed this Jan 21, 2017
@ibnesayeed ibnesayeed reopened this Jan 21, 2017
@ibnesayeed
Copy link
Contributor Author

Closed and reopened to trigger CI builds because some builds are failing due to Travis issue.

@ibnesayeed ibnesayeed closed this Jan 21, 2017
@ibnesayeed ibnesayeed reopened this Jan 21, 2017
@ibnesayeed ibnesayeed closed this Jan 21, 2017
@ibnesayeed ibnesayeed reopened this Jan 21, 2017
@ibnesayeed
Copy link
Contributor Author

Finally, all the builds passed. It's safe and desired to be merged now.

@ibnesayeed ibnesayeed changed the title Fixed test failutres if redis is not running WIP: Add support to reset trained classifiers to their initial state Jan 21, 2017
@ibnesayeed
Copy link
Contributor Author

Please don't merge it yet. I am pushing some more changes in it.

@Ch4s3
Copy link
Member

Ch4s3 commented Jan 21, 2017

Sounds good

@ibnesayeed ibnesayeed changed the title WIP: Add support to reset trained classifiers to their initial state Add support to reset trained classifiers to their initial state Jan 21, 2017
@ibnesayeed
Copy link
Contributor Author

This is done, please go ahead and merge it unless you have any code reviews.

@ibnesayeed ibnesayeed mentioned this pull request Jan 21, 2017
Closed
@ibnesayeed
Copy link
Contributor Author

Marking it done from my end.

@ibnesayeed
Copy link
Contributor Author

@Ch4s3, I have resolved conflicts and it is ready to merge now.

@ibnesayeed
Copy link
Contributor Author

@Ch4s3 is there anything blocking here in getting it merged? I was thinking of finalizing some other changes after my pending PRs are merged. I wanted to try to avoid dealing with multiple branches, that's why waiting everything to be merged.

@Ch4s3
Copy link
Member

Ch4s3 commented Feb 8, 2017

@ibnesayeed sorry, I was taking some time off from open source stuff for health reasons. It looks good!

@Ch4s3 Ch4s3 merged commit 67be2f5 into jekyll:master Feb 8, 2017
@ibnesayeed ibnesayeed deleted the test-fix branch February 8, 2017 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibnesayeed @Ch4s3