JRuby support! #168
Merged
JRuby support! #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mach-kernel
force-pushed
the
jruby-support
branch
4 times, most recently
from
9e67aa2
to
430047b
Compare
|
@mach-kernel Awesome! Thanks for the contribution. Could you remove the change to |
mach-kernel
force-pushed
the
jruby-support
branch
3 times, most recently
from
342cee9
to
d3bea6b
Compare
|
@Ch4s3 Travis seems to be happy now, I made the requested changes. As for the gem, I think you can push out different versions per platform and retain the same name but it's difficult to orchestrate. Note that the other |
mach-kernel
force-pushed
the
jruby-support
branch
from
d3bea6b
to
c08c440
Compare
|
Excellent! I'll take a look tomorrow |
|
Thanks @mach-kernel! I'll try to roll a release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I've been using this library's Bayes classifier for a while and didn't really see any reason why it wasn't possible to use in JRuby other than the dependency of
fast_stemmer. I found that someone made a wrapper around the Porter Stemmer reference. I'm using my fork because of some import issues, but otherwise it is unchanged from the original.It appears that all the tests pass. I am happy to test other functionality and write some docs for this.
Thanks much!