Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slug in liquid templates #100

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use slug in liquid templates #100

wants to merge 3 commits into from

Conversation

fauno
Copy link
Member

@fauno fauno commented Jun 12, 2017

I needed to use the slug on a layout and nothing was being printed until I realized the attribute isn't available in liquid :)

@parkr
Copy link
Member

parkr commented Oct 26, 2017

/cc #113

I needed to use the slug on a layout and nothing was being printed until I realized the attribute isn't available in liquid :)
@ashmaroli
Copy link
Member

ashmaroli commented Apr 29, 2020

Superseded by #129

@ashmaroli ashmaroli closed this Apr 29, 2020
@fauno
Copy link
Member Author

fauno commented Apr 29, 2020

@ashmaroli hi, can i ask why this pr went ignored for three years and then a newer one that implements the same feature gets accepted?

@ashmaroli
Copy link
Member

Hi @fauno
Technically yes, both PRs have a common ground.
But mainly, this one was about having a slug attribute exposed via Liquid. Like, rendering value via {{ page.slug }}. But the intention was not clear.. there were no tests to demonstrate the expected results either.

Looking at this again, this is not the same feature as what is on current master..
You are welcome to rebase to master, and add some tests.

@ashmaroli ashmaroli reopened this Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants