Add tests #16
Add tests #16
Conversation
|
AppVeyor is SO SLOW |
| actual = commonmark.convert("https://example.com") | ||
| expected = "https://example.com" | ||
| expect(actual).to match(expected) | ||
| end |
There was a problem hiding this comment.
IMO, there should also be a test for Markdown links
commonmark.convert("[example](https://example.com)")
commonmark.convert("[example][link]\n\n[link]: https://example.com")
There was a problem hiding this comment.
Remember that we're not testing the MarkDown processor itself, merely our interface to the MarkDown processor. If the MarkDown processor does not conform to the CommonMark spec, its own tests will reveal that. 👍
That said, if there is a reason to add this test, it would not be difficult.
There was a problem hiding this comment.
Ah I see.. is there any aspect where our interface markedly differs from kramdown? If yes, then that should definitely be tested (will serve as documentation) because the HTML markup is going to change when users switch to this parser..
spec/spec_helper.rb
Outdated
| TMP_DIR = File.expand_path("../tmp", TEST_DIR) | ||
|
|
||
| require "jekyll" | ||
| require File.expand_path("../lib/jekyll-commonmark.rb", TEST_DIR) |
There was a problem hiding this comment.
can't we use require_relative "jekyll-commonmark" instead?
yeah.., also the fact that it doesn't allow running parallel builds for the free accounts further increases the total time.. |
|
@jekyllbot: merge +dev |
PR automatically created for @pathawks.
Fixes #14