Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media:content tag #290

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Add media:content tag #290

merged 2 commits into from
Nov 12, 2019

Conversation

torrocus
Copy link
Contributor

@torrocus torrocus commented Nov 12, 2019

Add media:content tag which is using by mail templates like Mailchimp.
I decided to finish what started @ladyd252 and @mikepsinn.
Original pull requests:

I only corrected what needed to be changed and added tests.

Quote from the Mailchimp website:

To help ensure that Mailchimp can view your feed's images, you can include medium or type information inside the media:content tag.

@torrocus
Copy link
Contributor Author

@DirtyF & @ashmaroli, could you take a look?

Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one change needed.

History.markdown Outdated Show resolved Hide resolved
@parkr
Copy link
Member

parkr commented Nov 12, 2019

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit a9d4bd9 into jekyll:master Nov 12, 2019
jekyllbot added a commit that referenced this pull request Nov 12, 2019
DirtyF added a commit that referenced this pull request Nov 13, 2019
Minor enhancements:

  * Excerpt only flag (#287)
  * Add media:content tag (#290)

Fix #283
@jekyllbot jekyllbot mentioned this pull request Nov 13, 2019
@DirtyF
Copy link
Member

DirtyF commented Nov 13, 2019

@torrocus thanks released in https://github.com/jekyll/jekyll-feed/releases/tag/v0.13.0

@jekyll jekyll locked and limited conversation to collaborators Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants