Allow skipping generation in development #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
reviewed
Dec 16, 2021
There was a problem hiding this comment.
This is a good example of a "power-user" feature – one that most folks won't need but that can help for those with big sites. You just have to remember to set JEKYLL_ENV=production when building your site to push out to the world with this option on!
I think we can iterate on the flag name, otherwise things look good.
|
|
||
| ```yml | ||
| feed: | ||
| skip_development: true |
There was a problem hiding this comment.
I think we could improve this name a bit. What do you think about disable_in_development or skip_in_development?
| @@ -8,6 +8,8 @@ class Generator < Jekyll::Generator | |||
| # Main plugin action, called by Jekyll-core | |||
| def generate(site) | |||
| @site = site | |||
| return if config["skip_development"] == true && Jekyll.env == "development" | |||
There was a problem hiding this comment.
Let's log in this case so it's clear to the user what's happening. Something like:
Jekyll.logger.info "Jekyll Feed:", "Skipping feed generation in development"
|
Fixed by #370! |
|
No worries, thanks for getting us all started! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #331