Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no need to notify cache expiration in getItem function when skipTTLExtension is true #55

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

chenyahui
Copy link
Contributor

@chenyahui chenyahui commented Oct 13, 2021

There is no need to notify the cache to change expiration when just get item and doesn't extend TTL, because of the priorityQueue will not changed.

@ReneKroon ReneKroon merged commit a6a215b into jellydator:master Oct 14, 2021
@ReneKroon
Copy link
Contributor

Not sure why the Travis build fails for PR, but it has to do with token for coverage tool. This change is ok 👍

@chenyahui chenyahui deleted the get_item branch October 14, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants