-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for playlists in external player #267
Fix support for playlists in external player #267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but have you checked how this works with something like the intros plugin?
@CarlosOlivo if you do end up testing the intros plugin, please let me know if the settings can be changed from the defaults on the latest version. I'm getting reports about that, but I've checked on my server and it seems to be working. |
930ed73
to
6b39234
Compare
Well... fixed! (?)
I do not know about the previous versions since it is the first time I have tried the intros plugin but at least in version 1.2.1.0 it allows me to change the default settings. |
Won't this fix cause the same issue to happen when pressing back during an intro? |
As long as at least a millisecond spends playing the intro, the intro is marked as seen and plays the next item. |
From my testing this does not work with intros. It will play the intro and after that nothing happens, no movie is showing up for me. Tested with 10.7 between RC1/RC2 in |
6b39234
to
fc08a5d
Compare
Oh sorry, I forgot to add a Also RIP Azure pipeline
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Pressing the back button during the intro will still open the movie so you'd need to press back again. I guess that's something we'll have to live with until playlist management is implemented natively. @Maxr1998 what do you think? |
Guess that'd be acceptable, yes. |
Only allow intros, a single item to play and stop as there is no way to stop a playlist from an external player. Co-authored-by: Niels van Velzen <git@ndat.nl>
fc08a5d
to
a117e88
Compare
Only allow intros, a single item to play and stop as there is no way to stop a playlist from an external player.
Closes #265