Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for playlists in external player #267

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

CarlosOlivo
Copy link
Contributor

@CarlosOlivo CarlosOlivo commented Dec 12, 2020

Only allow intros, a single item to play and stop as there is no way to stop a playlist from an external player.

Closes #265

Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but have you checked how this works with something like the intros plugin?

@dkanada
Copy link
Member

dkanada commented Dec 13, 2020

@CarlosOlivo if you do end up testing the intros plugin, please let me know if the settings can be changed from the defaults on the latest version. I'm getting reports about that, but I've checked on my server and it seems to be working.

@CarlosOlivo
Copy link
Contributor Author

LGTM, but have you checked how this works with something like the intros plugin?

Well... fixed! (?)

@CarlosOlivo if you do end up testing the intros plugin, please let me know if the settings can be changed from the defaults on the latest version. I'm getting reports about that, but I've checked on my server and it seems to be working.

I do not know about the previous versions since it is the first time I have tried the intros plugin but at least in version 1.2.1.0 it allows me to change the default settings.

@nielsvanvelzen
Copy link
Member

Won't this fix cause the same issue to happen when pressing back during an intro?

@CarlosOlivo
Copy link
Contributor Author

Won't this fix cause the same issue to happen when pressing back during an intro?

As long as at least a millisecond spends playing the intro, the intro is marked as seen and plays the next item.

@nielsvanvelzen
Copy link
Member

nielsvanvelzen commented Dec 17, 2020

From my testing this does not work with intros. It will play the intro and after that nothing happens, no movie is showing up for me.

Tested with 10.7 between RC1/RC2 in

@CarlosOlivo
Copy link
Contributor Author

From my testing this does not work with intros. It will play the intro and after that nothing happens, no movie is showing up for me.

Tested with 10.7 between RC1/RC2 in

Oh sorry, I forgot to add a this in 10.7, try again.


Also RIP Azure pipeline

> Could not resolve all artifacts for configuration ':buildSrc:classpath'.
   > Could not resolve org.gradle.kotlin:plugins:1.3.6.
     Required by:
         project :buildSrc > org.gradle.kotlin.kotlin-dsl:org.gradle.kotlin.kotlin-dsl.gradle.plugin:1.3.6
      > Could not resolve org.gradle.kotlin:plugins:1.3.6.
         > Could not get resource 'https://plugins.gradle.org/m2/org/gradle/kotlin/plugins/1.3.6/plugins-1.3.6.module'.
            > Could not GET 'https://jcenter.bintray.com/org/gradle/kotlin/plugins/1.3.6/plugins-1.3.6.module'. Received status code 502 from server: Bad Gateway

@nielsvanvelzen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nielsvanvelzen
Copy link
Member

Pressing the back button during the intro will still open the movie so you'd need to press back again. I guess that's something we'll have to live with until playlist management is implemented natively. @Maxr1998 what do you think?

@Maxr1998
Copy link
Member

Maxr1998 commented Dec 17, 2020

Guess that'd be acceptable, yes.

Only allow intros, a single item to play and stop as there is no way to stop a playlist from an external player.

Co-authored-by: Niels van Velzen <git@ndat.nl>
@Maxr1998 Maxr1998 merged commit 1596d04 into jellyfin:master Dec 17, 2020
@CarlosOlivo CarlosOlivo deleted the fix-playlists-external-player branch December 18, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media playback does not always respect External Player preference
4 participants