Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous casting fixes #287

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Conversation

nielsvanvelzen
Copy link
Member

  • Added a few logging statements
  • Made the execCast and castCallback async so the JS engine will behave slightly different in the way everything is called
    • This fixes the unstable client never loading
  • Change how the chrome cast plugin is loaded to MITM the google url instead

Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I would reorder the statements a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants