Chromecast JS: Improve error logging. #322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating an issue I was having with casting
(which has been fixed somewhere between the Playstore release and the tip ofand found whenever the Chromecast js logged an error it was not stringified and thus would logmaster
)[object Object]
.EDIT: Actually my issue is still present when using the gradle options to build, will raise an issue.
This PR addresses this by attempting to stringify the instance of
chrome.cast.Error
, if this fails or throws then the original behaviour will be used.Before:
After: