Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(publish): add initial publish app GH workflow #330

Merged
merged 4 commits into from
May 21, 2021

Conversation

h1dden-da3m0n
Copy link
Contributor

@h1dden-da3m0n h1dden-da3m0n commented Mar 28, 2021

Description

This is an initial attempt on offering a replacement for the sol remaining Azure CI workflow.
Any feedback is welcome and the are still at least 2 steps missing from the original workflow (namely: CopyFilesOverSSH, SSH, mostly since I don't know what they are exactly used for or how to replicate them).

Changes

  • Add publish GitHub workflow

Issues

  • n/a (move from Azure CI to GH Actions)

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Only reviewed until the signing part)

Ideally the publishing workflow also publishes test versions (on the master branch) that are not signed. The Kotlin SDK works similarly. See https://github.com/jellyfin/jellyfin-sdk-kotlin/blob/5d1d7e3600d8f9d2f98dd5dbc2a68f4090f4f416/.github/workflows/sdk-publish.yaml

.github/workflows/publish.yaml Outdated Show resolved Hide resolved
.github/workflows/publish.yaml Outdated Show resolved Hide resolved
.github/workflows/publish.yaml Outdated Show resolved Hide resolved
@h1dden-da3m0n
Copy link
Contributor Author

okay, I am not 100% on the repo upload script NGL. Please let me know what you think of that, otherwise this should cover the requirements to this workflow.
There are a few secrets that would be required to be added to the repo should the workflow in its current form be accepted, but I expect this to still go throug an iteration or two.

Note I plan to squash the workflow commits in the end unless you want the full history, but this should be discussed at the end.

@h1dden-da3m0n h1dden-da3m0n force-pushed the ci/workflow-publish branch 2 times, most recently from 72d3165 to 248bb6b Compare April 2, 2021 17:47
@h1dden-da3m0n h1dden-da3m0n marked this pull request as ready for review April 2, 2021 17:47
@h1dden-da3m0n
Copy link
Contributor Author

okay I opted to remove my shell script in favor of two actions, I found them to be more straight forward (however I can always revert if you like the script more)
There are several secrets that this workflow would require to be added to this repo before it would work and I still need to squash the workflow commits, but functionality wise it should be equivalent to the Azure CI pipeline.

.github/workflows/app-publish.yaml Outdated Show resolved Hide resolved
.github/workflows/app-publish.yaml Outdated Show resolved Hide resolved
.github/workflows/app-publish.yaml Outdated Show resolved Hide resolved
.github/workflows/app-publish.yaml Outdated Show resolved Hide resolved
.github/workflows/app-publish.yaml Outdated Show resolved Hide resolved
.github/workflows/app-publish.yaml Outdated Show resolved Hide resolved
.github/workflows/app-publish.yaml Outdated Show resolved Hide resolved
.github/workflows/app-publish.yaml Outdated Show resolved Hide resolved
@nielsvanvelzen nielsvanvelzen self-requested a review April 4, 2021 20:04
@h1dden-da3m0n h1dden-da3m0n force-pushed the ci/workflow-publish branch 7 times, most recently from 0d1dba6 to 1d2d559 Compare April 8, 2021 22:28
Co-authored-by: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
Co-authored-by: Maxr1998 <max.rumpf1998@gmail.com>
.github/workflows/app-build.yml Outdated Show resolved Hide resolved
.github/workflows/app-build.yml Outdated Show resolved Hide resolved
.github/workflows/app-build.yml Show resolved Hide resolved
.github/workflows/app-build.yml Outdated Show resolved Hide resolved
.github/workflows/app-build.yml Outdated Show resolved Hide resolved
.github/workflows/app-build.yml Outdated Show resolved Hide resolved
.github/workflows/app-publish.yaml Show resolved Hide resolved
.github/workflows/app-publish.yaml Show resolved Hide resolved
Co-authored-by: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: do not merge until secrets are added.

@nielsvanvelzen nielsvanvelzen added the blocked Blocked for some reason label Apr 30, 2021
@nielsvanvelzen nielsvanvelzen self-assigned this Apr 30, 2021
Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for all secrets to be added before merging.

@nielsvanvelzen nielsvanvelzen removed the blocked Blocked for some reason label May 21, 2021
@nielsvanvelzen nielsvanvelzen merged commit 57be96f into jellyfin:master May 21, 2021
@h1dden-da3m0n h1dden-da3m0n deleted the ci/workflow-publish branch May 21, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants