-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(publish): add initial publish app GH workflow #330
ci(publish): add initial publish app GH workflow #330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Only reviewed until the signing part)
Ideally the publishing workflow also publishes test versions (on the master branch) that are not signed. The Kotlin SDK works similarly. See https://github.com/jellyfin/jellyfin-sdk-kotlin/blob/5d1d7e3600d8f9d2f98dd5dbc2a68f4090f4f416/.github/workflows/sdk-publish.yaml
63ab649
to
dc237ae
Compare
f4ad253
to
f3920ca
Compare
okay, I am not 100% on the repo upload script NGL. Please let me know what you think of that, otherwise this should cover the requirements to this workflow. Note I plan to squash the workflow commits in the end unless you want the full history, but this should be discussed at the end. |
72d3165
to
248bb6b
Compare
okay I opted to remove my shell script in favor of two actions, I found them to be more straight forward (however I can always revert if you like the script more) |
248bb6b
to
6cbb6d1
Compare
0d1dba6
to
1d2d559
Compare
1d2d559
to
6a6df12
Compare
Co-authored-by: Niels van Velzen <nielsvanvelzen@users.noreply.github.com> Co-authored-by: Maxr1998 <max.rumpf1998@gmail.com>
6a6df12
to
861b448
Compare
9e64cbf
to
e449d92
Compare
Co-authored-by: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
e449d92
to
e9ff845
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: do not merge until secrets are added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Waiting for all secrets to be added before merging.
Description
This is an initial attempt on offering a replacement for the sol remaining Azure CI workflow.
Any feedback is welcome and the are still at least 2 steps missing from the original workflow (namely:
CopyFilesOverSSH
,SSH
, mostly since I don't know what they are exactly used for or how to replicate them).Changes
Issues