Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to SDK beta 8 #427

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Update to SDK beta 8 #427

merged 2 commits into from
Jun 14, 2021

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Jun 13, 2021 •
edited
Loading

  • Bump SDK to beta 8
  • Remove ApiController.currentUser in favor of ApiClient.userId
  • Remove ApiController.requireUser in favor of ApiClient.userId
  • Remove ApiController.currentDeviceId in favor of ApiClient.deviceInfo.id
  • Remove explicit userId parameter when not required (replaced with SDK autofill)

@nielsvanvelzen nielsvanvelzen force-pushed the sdk-userid branch 2 times, most recently from 9f76c7b to a249e8b Compare June 13, 2021 10:27
@nielsvanvelzen nielsvanvelzen added the backport Pull request needs to be backported to current release branch label Jun 13, 2021
@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review June 13, 2021 10:39
@Maxr1998 Maxr1998 enabled auto-merge June 14, 2021 12:43
@Maxr1998 Maxr1998 merged commit bfcaecb into jellyfin:master Jun 14, 2021
@nielsvanvelzen nielsvanvelzen deleted the sdk-userid branch June 14, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maxr1998 Maxr1998 Maxr1998 approved these changes

Assignees
No one assigned
Labels
backport Pull request needs to be backported to current release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @Maxr1998