Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow skip forward/back length on ExoPlayer #441

Merged

Conversation

CarlosOlivo
Copy link
Contributor

Closes #84

@Maxr1998 Maxr1998 added enhancement New feature or request exoplayer Related to the ExoPlayer integration labels Jun 18, 2021
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Aug 30, 2021
@Maxr1998 Maxr1998 force-pushed the follow-skip-length-native-player branch from 44dd1d8 to fd92c57 Compare October 1, 2021 20:33
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Oct 1, 2021
Co-authored-by: Maxr1998 <max.rumpf1998@gmail.com>
@Maxr1998 Maxr1998 force-pushed the follow-skip-length-native-player branch from fd92c57 to bcf3190 Compare October 1, 2021 20:41
Maxr1998
Maxr1998 previously approved these changes Oct 1, 2021
@Maxr1998
Copy link
Member

Maxr1998 commented Oct 1, 2021

Add an extra model class to store the display preferences, that way the number only has to be parsed once. Rest works well.

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding a fragile HTTP interceptor it might be easier to just GET the display preferences when the player starts. That should be more reliable.

@Maxr1998
Copy link
Member

Maxr1998 commented Oct 1, 2021

True that, I'll do that.

@Maxr1998 Maxr1998 enabled auto-merge (squash) October 1, 2021 21:22
@Maxr1998 Maxr1998 merged commit be10242 into jellyfin:master Oct 1, 2021
@CarlosOlivo CarlosOlivo deleted the follow-skip-length-native-player branch October 1, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exoplayer Related to the ExoPlayer integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip forward and back doesn't follow settings in exoplayer
4 participants