Implement media segments #4052
Merged
Implement media segments #4052
+218
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -64,7 +64,7 @@ | |||
| private Limiter mLimiter; | |||
| private PlaybackControllerNotifiable mPlaybackControllerNotifiable; | |||
| private PlaybackOverlayFragmentHelper _helper; | |||
| private ExoPlayer mExoPlayer; | |||
| public ExoPlayer mExoPlayer; | |||
Check notice
Code scanning / Android Lint
Unknown nullness Note
| NOTHING(R.string.segment_action_nothing), | ||
|
|
||
| /** | ||
| * Seek to the end of this segment (endTicks). If the duration of this segment is shorter than 1 second it should do nothing to avoid |
Check warning
Code scanning / detekt
Line detected, which is longer than the defined maximum line length in the code style. Warning
app/src/main/java/org/jellyfin/androidtv/ui/playback/segment/MediaSegmentAction.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/ui/playback/segment/MediaSegmentAction.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/ui/playback/PlaybackControllerHelper.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/ui/playback/PlaybackControllerHelper.kt
Fixed
Show fixed
Hide fixed
|
|
||
| /** | ||
| * Seek to the end of this segment (endTicks). If the duration of this segment is shorter than 1 second it should do nothing to avoid | ||
| * lagg. The skip action will only execute when playing over the segment start, not when seeking into the segment block. |
Check warning
Code scanning / detekt
Line detected, which is longer than the defined maximum line length in the code style. Warning
app/src/main/java/org/jellyfin/androidtv/ui/playback/segment/MediaSegmentAction.kt
Fixed
Show fixed
Hide fixed
nielsvanvelzen
force-pushed
the
media-segments
branch
from
48cdeda
to
941317d
Compare
nielsvanvelzen
added
enhancement
nielsvanvelzen
force-pushed
the
media-segments
branch
from
941317d
to
6cdec33
Compare
crobibero
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the initial support for media segments with some of the actions I'd like still missing.
Changes
The
MediaSegmentRepositorycontains a hardcoded list of supported segment types that is always included when requesting segments. This way we can add new segment types on the backend without breaking existing app releases (SDK won't be able to parse an unknown enum). Additionally, I've opted to not support the "unknown" type in the client.Future additions will include:
I'm not sure how many of these will be implemented within the current playback code as it's a bit finicky to work with.
Screenshots
Issues